Skip to content

[Update] numpy 2.x series#389

Closed
FlorianDeconinck wants to merge 22 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:update/numpy_2x
Closed

[Update] numpy 2.x series#389
FlorianDeconinck wants to merge 22 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:update/numpy_2x

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck commented Mar 2, 2026

Description

Catching up to our upstream dependency and pushing NDSL to support numpy 2.x.

In order to not be brought back into the past, I propose we force the usage of 2.x

Downstream:

  • NumpyModules in ndsl.types was a shadow class used for type hinting between cupy and numpy. With the numpy API evolving, the shadow class would explode in complexity

How has this been tested?

Running unit test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@romanc
Copy link
Copy Markdown
Collaborator

romanc commented Mar 3, 2026

In order to not be brought back into the past, I propose we force the usage of 2.x

Sounds good. GT4Py anyway wants to drop support for numpy 1.x as well. If we enforce numpy 2.x in NDSL, I think they'd be more than happy to move to numpy 2.x only in GT4Py too.

@romanc romanc mentioned this pull request Mar 6, 2026
7 tasks
@FlorianDeconinck
Copy link
Copy Markdown
Collaborator Author

Closed - superseded by #415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants