Skip to content

refactor: deprecate gt4py_utils.zeros() in favor of xumpy.zeros()#388

Merged
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/gt4py-utils-xumpy
Mar 31, 2026
Merged

refactor: deprecate gt4py_utils.zeros() in favor of xumpy.zeros()#388
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/gt4py-utils-xumpy

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Feb 27, 2026

Description

gt4py_utils has a zeros() function, which is the same as xumpy.zeros(). This PR suggests to deprecate the one in gt4py_utils over the new one in xumpy.

There are a bunch of other functions in gt4py_utils that could be moved to xumpy. We can add them here for this release or do them in a follow-up PR for the next release.

How has this been tested?

Covered by existing tests: make_storage_data() (which is now based on xumpy.zeros()) is used to setup data in the translate test system.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/): N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

@romanc romanc force-pushed the romanc/gt4py-utils-xumpy branch 2 times, most recently from 73e2c4f to bdc7693 Compare March 3, 2026 14:19
@romanc romanc force-pushed the romanc/gt4py-utils-xumpy branch from 7997289 to 6241cbc Compare March 31, 2026 13:52
@romanc romanc changed the title WIP: move things from gt4py_utils to xumpy refactor: deprecate gt4py_utils.zeros() in favor of xumpy.zeros() Mar 31, 2026
@romanc romanc marked this pull request as ready for review March 31, 2026 14:42
@romanc romanc requested a review from FlorianDeconinck March 31, 2026 14:43
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Mar 31, 2026
Merged via the queue into NOAA-GFDL:develop with commit da721f1 Mar 31, 2026
7 checks passed
@romanc romanc deleted the romanc/gt4py-utils-xumpy branch April 1, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants