Skip to content

[Fix] [Translate] Update API for parallel test when using MultiModalMetric #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianDeconinck merged 2 commits into from
Nov 26, 2025
Merged

[Fix] [Translate] Update API for parallel test when using MultiModalMetric #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d86d81
Remove old options for `MultiModalFloatMetric`
FlorianDeconinck Nov 26, 2025
dae63a9
Defensive programming: bail out if we can't measure the ref vs input …
FlorianDeconinck Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ndsl/stencils/testing/test_translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,6 @@ def test_parallel_savepoint(
absolute_eps_override=case.testobj.mmr_absolute_eps,
relative_fraction_override=case.testobj.mmr_relative_fraction,
ulp_override=case.testobj.mmr_ulp,
ignore_near_zero_errors=ignore_near_zero,
near_zero=case.testobj.near_zero,
sort_report=case.sort_report,
)
else:
Expand Down
4 changes: 3 additions & 1 deletion ndsl/testing/comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,9 @@ def __init__(
self.check = np.all(self.success)
self.sort_report = sort_report

if input_values is not None:
# We might have sliced outputs in the translate test. Rather than funnel the slicing
# all the way down, we bail out if we can measure input vs reference
if input_values is not None and input_values.shape == reference_values.shape:
self.number_changing_values = (
(input_values != reference_values).flatten().shape[0]
)
Expand Down