refactor: remove --no_legacy_namelist option of pytest

[romanc]

Description

This is a follow-up from PR #297.

How has this been tested?

Not

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas: N/A
• I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/): N/A
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules: N/A
• New check tests, if applicable, are included: N/A

[jjuyeonkim]

I think this makes sense. We just need to remove it from the pyFV3 and pySHiELD workflows. Sorry for being slow about that. I can put in some small PRs to do that, if you haven't already.

[romanc]

ah nevermind - we need to wait for pace to update. there's a release coming at the end of this month. we can do it after that. sorry for the noise.

[fmalatino]

ah nevermind - we need to wait for pace to update. there's a release coming at the end of this month. we can do it after that. sorry for the noise.

@romanc A planned release of NDSL or Pace?

[romanc]

ah nevermind - we need to wait for pace to update. there's a release coming at the end of this month. we can do it after that. sorry for the noise.

@romanc A planned release of NDSL or Pace?

The NASA team is planning another NDSL release at the end of this month. Florian will talk more about that tomorrow in the sync meeting.

[romanc]

I think this makes sense. We just need to remove it from the pyFV3 and pySHiELD workflows. Sorry for being slow about that. I can put in some small PRs to do that, if you haven't already.

I might have closed this one a tad too early. @jjuyeonkim, you are right, we just need to remove it from the pyFV3 and pySHiELD workflows and then we can merge. If you would do these two small PR in pyFV3 and pySHiELD that would be fantastic. Then we can get this out of NDSL before the end of the month and the next release will be clean of any ndsl.Namelist remnants.

(I was mistakenly under the impression that this would depend on a submodule update of NDSL in pace, which I think makes sense again as soon as we release the next version of NDSL.)

[romanc]

(re-opening now - I pressed the wrong button)

Edit: I can't seem to be able to re-open. Let's just make a new one once pyFV3 an pySHiELD are updated ...