Skip to content

refactor: directly use gt_storage in QuantityFactory #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianDeconinck merged 1 commit into from
Nov 5, 2025
Merged

refactor: directly use gt_storage in QuantityFactory #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 13 additions & 32 deletions ndsl/initialization/allocator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,6 @@
from ndsl.quantity import Quantity, QuantityHaloSpec


class _Allocator:
def __init__(self, backend: str) -> None:
"""
Initialize an object that provides gt4py storage objects for zeros(), ones(), and empty().

Args:
backend: GT4Py backend name used for performance-optimized allocation.
"""
self.backend = backend

def empty(self, *args: Any, **kwargs: Any) -> np.ndarray:
return gt_storage.empty(*args, backend=self.backend, **kwargs)

def ones(self, *args: Any, **kwargs: Any) -> np.ndarray:
return gt_storage.ones(*args, backend=self.backend, **kwargs)

def zeros(self, *args: Any, **kwargs: Any) -> np.ndarray:
return gt_storage.zeros(*args, backend=self.backend, **kwargs)


class QuantityFactory:
def __init__(self, sizer: GridSizer, *, backend: str) -> None:
"""
Expand All @@ -45,8 +25,6 @@ def __init__(self, sizer: GridSizer, *, backend: str) -> None:
self.sizer = sizer
self.backend = backend

self._allocator = _Allocator(self.backend)

def update_data_dimensions(
self,
data_dimension_descriptions: dict[str, int],
Expand Down Expand Up @@ -111,7 +89,7 @@ def empty(

Equivalent to `numpy.empty`"""
return self._allocate(
self._allocator.empty, dims, units, dtype, allow_mismatch_float_precision
gt_storage.empty, dims, units, dtype, allow_mismatch_float_precision
)

def zeros(
Expand All @@ -126,7 +104,7 @@ def zeros(

Equivalent to `numpy.zeros`"""
return self._allocate(
self._allocator.zeros, dims, units, dtype, allow_mismatch_float_precision
gt_storage.zeros, dims, units, dtype, allow_mismatch_float_precision
)

def ones(
Expand All @@ -141,7 +119,7 @@ def ones(

Equivalent to `numpy.ones`"""
return self._allocate(
self._allocator.ones, dims, units, dtype, allow_mismatch_float_precision
gt_storage.ones, dims, units, dtype, allow_mismatch_float_precision
)

def full(
Expand All @@ -157,7 +135,7 @@ def full(

Equivalent to `numpy.full`"""
quantity = self._allocate(
self._allocator.empty,
gt_storage.empty,
dims,
units,
dtype,
Expand Down Expand Up @@ -235,12 +213,15 @@ def _allocate(
zip(dims, ("I", "J", "K", *([None] * (len(dims) - 3))))
)
]
try:
data = allocator(
shape, dtype=dtype, aligned_index=origin, dimensions=dimensions
)
except TypeError:
data = allocator(shape, dtype=dtype)

data = allocator(
shape,
dtype=dtype,
aligned_index=origin,
dimensions=dimensions,
backend=self.backend,
)

return Quantity(
data,
dims=dims,
Expand Down