Skip to content

BREAKING CHANGE: removal of extra_dim_lengths #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanc merged 1 commit into from
Oct 31, 2025
Merged

BREAKING CHANGE: removal of extra_dim_lengths #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions ndsl/initialization/allocator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,6 @@ def __init__(self, sizer: GridSizer, *, backend: str) -> None:

self._allocator = _Allocator(self.backend)

def set_extra_dim_lengths(self, **kwargs: Any) -> None:
"""
Set the length of extra (non-x/y/z) dimensions.
"""
warnings.warn(
"`QuantityFactory.set_extra_dim_lengths` is deprecated. "
"Use `add_data_dimensions` or `update_data_dimensions`.",
DeprecationWarning,
2,
)
self.sizer.data_dimensions.update(kwargs)

def update_data_dimensions(
self,
data_dimension_descriptions: dict[str, int],
Expand Down
10 changes: 0 additions & 10 deletions ndsl/initialization/grid_sizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import warnings
from collections.abc import Sequence
from dataclasses import dataclass

Expand All @@ -16,15 +15,6 @@ class GridSizer:
data_dimensions: dict[str, int]
"""Name/Lengths pair of any non-x/y/z dimensions, such as land or radiation dimensions."""

@property
def extra_dim_lengths(self) -> dict[str, int]:
warnings.warn(
"`GridSizer.extra_dim_lengths` is a deprecated API, use `GridSizer.data_dimensions`.",
DeprecationWarning,
2,
)
return self.data_dimensions

def get_origin(self, dims: Sequence[str]) -> tuple[int, ...]:
raise NotImplementedError()

Expand Down