Skip to content

Patch domain checks to only happen once #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twicki merged 7 commits into from
Oct 30, 2025
Merged

Patch domain checks to only happen once #293

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5873888
For release `2025.03.00` (#127)
fmalatino Apr 3, 2025
a9179be
Merge commit '4a1abd4'
fmalatino Jun 2, 2025
b5c87d0
Merge pull request #161 from NOAA-GFDL/main_history_fix
FlorianDeconinck Jun 2, 2025
808dd20
Merge pull request #162 from NOAA-GFDL/develop
FlorianDeconinck Jun 2, 2025
66ca013
Release `2025.10.00` (PR #289 from NOAA-GFDL/develop)
romanc Oct 28, 2025
187d14a
check domain size args only once
twicki Oct 29, 2025
158dd12
review & test
twicki Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ndsl/dsl/stencil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,8 @@ def __init__(
else:
self._timing_collector = timing_collector

self.arguments_already_checked = False
Comment thread
romanc marked this conversation as resolved.
Outdated

if externals is None:
externals = {}
self.externals = externals
Expand Down Expand Up @@ -406,7 +408,12 @@ def __call__(self, *args: Any, **kwargs: Any) -> None:
if self.stencil_config.verbose:
ndsl_log.debug(f"Running {self._func_name}")

self._validate_quantity_sizes(*args, **kwargs)
if (
not self.arguments_already_checked
and self.stencil_config.compilation_config.validate_args
):
self._validate_quantity_sizes(*args, **kwargs)
self.arguments_already_checked = True

# Marshal arguments
args_list = list(args)
Expand All @@ -430,7 +437,10 @@ def __call__(self, *args: Any, **kwargs: Any) -> None:
ndsl_debugger.track_data(all_args, self._func_qualname, is_in=True)

# Execute stencil
if self.stencil_config.compilation_config.validate_args:
if (
not self.arguments_already_checked
and self.stencil_config.compilation_config.validate_args
):
Comment thread
romanc marked this conversation as resolved.
if __debug__ and "origin" in kwargs:
raise TypeError("origin cannot be passed to FrozenStencil call")
if __debug__ and "domain" in kwargs:
Expand Down
Loading