Skip to content

Propagate Halo Information#274

Merged
twicki merged 3 commits into
NOAA-GFDL:developfrom
twicki:halo_propagation
Oct 23, 2025
Merged

Propagate Halo Information#274
twicki merged 3 commits into
NOAA-GFDL:developfrom
twicki:halo_propagation

Conversation

@twicki
Copy link
Copy Markdown
Collaborator

@twicki twicki commented Oct 23, 2025

Description

With #265 we are now storing the halo-data of quanitities.
Since we have a few spaces in NDSL where we create new quanitites from existing ones, that information needs to be propagated. This is done here.

How has this been tested?

Full Dycore run and check that every Quantity has the appropriate halo size

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@twicki twicki added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NOAA-GFDL:develop with commit ffb1c3c Oct 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants