Skip to content

BREAKING CHANGE: remove unused global configuration#260

Merged
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/cleanup-global-config
Oct 13, 2025
Merged

BREAKING CHANGE: remove unused global configuration#260
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/cleanup-global-config

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Oct 13, 2025

Description

According to @FlorianDeconinck, this global configuration is not used anymore and thus can and should be deleted. It was a way to "quickly configure" some things "back in the days".

This is a follow-up of #250 and in preparation for #257.

How has this been tested?

If anything was still using these functions, the compiler would complain (worst-case at runtime).

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A

Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have served faithfully, odd global file, rest in peace now

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NOAA-GFDL:develop with commit f0982bd Oct 13, 2025
5 checks passed
@romanc romanc deleted the romanc/cleanup-global-config branch October 13, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants