Deprecation of CopyCorners#240
Merged
Merged
Conversation
FlorianDeconinck
approved these changes
Sep 24, 2025
Collaborator
FlorianDeconinck
left a comment
There was a problem hiding this comment.
We need to mention - if not assert or try/catch in the model - that those are halo=3 tuned. Previous code was as well and that wasn't really said
8 tasks
romanc
reviewed
Sep 24, 2025
Collaborator
romanc
left a comment
There was a problem hiding this comment.
Looking good. I have two questions:
- Is
stencils/still the right folder now that corners aren't stencils anymore? - Is there any way we can do (simple) tests here in NDSL to ensure corners work correctly?
Collaborator
|
Let's move this inside |
CopyCorners
romanc
approved these changes
Oct 8, 2025
7 tasks
FlorianDeconinck
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After a deep-dive into how our model performs on CPU it became apparent that the CopyCorners codes were underperforming by a large margin. The implementation of those is happening in PyFV3 and therefore the
CopyCorernscalls are being deprecated here.How has this been tested?
Ran orchestrated & non-orchestrated regression tests (CopyCorners / FvTp2d and Del6VtFlux)
Checklist