Add domain-size checks on FrozenStencil#239
Conversation
|
Good to see this, we need to broadcast it. This might catch a ton of people off guard. I have seen things with K intervals/domains... |
|
So there's a main problem here: translate test are not quantity - and interface from GEOS might not be either. A second thing, once we have something stable, shouldn't we deactivate the |
FlorianDeconinck
left a comment
There was a problem hiding this comment.
Can we get a one time warning flagging that some stencils are not using Quantity and therefore won't validate there sizing properly - I want to capture people varied use case before we force "Quantities everywhere" (TM)
|
This is getting stale - let's get that warning in @twicki and push it in, I want this in the next release |
FlorianDeconinck
left a comment
There was a problem hiding this comment.
LGTM
Let's make sure we capture a thorough ticket for the rest of the work and link it here. Top of my head:
- clean up FV3 and/or option to run strict and fail instead of warn
- extract extent analysis from gt4py
Description
Since our Quantity-Factory generally allocates more memory than strictly needed (for gt4py-compatibility as well as memory alignment) as can be seen here, if a
Quantity's expected domain-size is too small for the execution domain of a stencil, it can be that we are not warned properly.This PR adds safe-guards around these calls to make sure we are not reading from memory that is technically allocated but never properly used.
How has this been tested?
New test has been added
Checklist