fix: stencil wrapper field origins with data_dims#216
Merged
romanc merged 1 commit intoSep 5, 2025
Merged
Conversation
Add support for fields with data_dims (or data_dims only fields) in the stencil wrapper's function to computae field origins.
twicki
approved these changes
Sep 5, 2025
Collaborator
twicki
left a comment
There was a problem hiding this comment.
This looks clean, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for fields with data_dims (or data_dims only fields) in the stencil wrapper's function to compute field origins.
This PR is work that's being propagated back from the nasa/milestone2 branch.
How Has This Been Tested?
Added new unit test. Tested locally with bigger reproducer (GFDL_1M orchestration).
Checklist: