Skip to content

Update gt4py: np.bool_ external and gtscript round()#207

Merged
romanc merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/gt4py-npbool-round
Aug 26, 2025
Merged

Update gt4py: np.bool_ external and gtscript round()#207
romanc merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/gt4py-npbool-round

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Aug 25, 2025

Description

This PR updates the GT4Py submodule fixing a bug with np.bool_ types when used as externals (missing support for that type in the ValueInliner). We now also expose round() and round_away_from_zero() in gtscript.

Fixes #203

How Has This Been Tested?

New tests in GT4Py.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A

This PR updates the GT4Py submodule fixing a bug with `np.bool_` types
when used as externals (missing support for that type in the
ValueInliner). We now also expose `round()` and `round_away_from_zero()`
in gtscript.
@romanc romanc requested a review from oelbert August 25, 2025 08:48
@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented Aug 25, 2025

@oelbert feel free to hit that merge button if you approve.

Copy link
Copy Markdown
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@romanc romanc added this pull request to the merge queue Aug 26, 2025
Merged via the queue into NOAA-GFDL:develop with commit 990736c Aug 26, 2025
5 checks passed
@romanc romanc deleted the romanc/gt4py-npbool-round branch September 2, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't inline Bool types

2 participants