Update gt4py: np.bool_ external and gtscript round()#207
Merged
Conversation
This PR updates the GT4Py submodule fixing a bug with `np.bool_` types when used as externals (missing support for that type in the ValueInliner). We now also expose `round()` and `round_away_from_zero()` in gtscript.
Collaborator
Author
|
@oelbert feel free to hit that merge button if you approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the GT4Py submodule fixing a bug with
np.bool_types when used as externals (missing support for that type in the ValueInliner). We now also exposeround()andround_away_from_zero()in gtscript.Fixes #203
How Has This Been Tested?
New tests in GT4Py.
Checklist: