Skip to content

tests: fix NaNs introduced into reference values #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanc merged 1 commit into from
Aug 14, 2025
Merged

tests: fix NaNs introduced into reference values #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ndsl/testing/comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,19 @@ def _compute_errors(
near_zero,
) -> npt.NDArray[np.bool_]:
if self.references.dtype in (np.float64, np.int64, np.float32, np.int32):
denom = self.references
denom[self.references == 0] = self.computed[self.references == 0]
# Rule number 1: Never touch the reference data!
denom = self.references.copy()
# Avoid division by 0. If reference is 0, we expect the computed value to be 0 too.
# (abs(computed - reference) / 1.0) is a good value for the error in this case.
denom[self.references == 0] = 1.0
self._calculated_metric = np.asarray(
np.abs((self.computed - self.references) / denom)
)
self._calculated_metric[denom == 0] = 0.0
elif self.references.dtype in (np.bool_, bool):
self._calculated_metric = np.logical_xor(self.computed, self.references)
else:
raise TypeError(
f"received data with unexpected dtype {self.references.dtype}"
f"Received data with unexpected dtype `{self.references.dtype}`."
)
success = np.logical_or(
np.logical_and(np.isnan(self.computed), np.isnan(self.references)),
Expand Down
Loading