Skip to content

Upgrade mpi4py to >4 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianDeconinck merged 4 commits into from
Jul 22, 2025
Merged

Upgrade mpi4py to >4 #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
829766e
Upgrade `mpi4py` to >4 to allow new unified allocator on GH box to no…
FlorianDeconinck Jul 21, 2025
c35f89a
Restrict further to bug fixed 4.1+
FlorianDeconinck Jul 21, 2025
f7f0bfd
A tad too strict
FlorianDeconinck Jul 21, 2025
55e1ed8
Use bare metal Ubuntu for NDSL unit tests
FlorianDeconinck Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,29 @@ concurrency:
jobs:
ndsl_unit_tests:
runs-on: ubuntu-latest
container:
image: ghcr.io/noaa-gfdl/miniforge:mpich
steps:

- name: Checkout repository
uses: actions/checkout@v4
with:
submodules: 'recursive'

- name: Setup Python 3.11
uses: actions/setup-python@v5
with:
python-version: '3.11'

- name: Install mpi (MPICH flavor)
run: pip3 install mpich

- name: Install Python packages
run: pip3 install .[test]

- name: Run serial-cpu tests
run: coverage run --rcfile=pyproject.toml -m pytest tests

- name: Run parallel-cpu tests
run: mpiexec -np 6 --oversubscribe coverage run --rcfile=pyproject.toml -m mpi4py -m pytest tests/mpi
run: mpiexec -np 6 coverage run --rcfile=pyproject.toml -m mpi4py -m pytest tests/mpi

- name: Output code coverage
run: |
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def local_pkg(name: str, relative_path: str) -> str:
requirements: list[str] = [
local_pkg("gt4py", "external/gt4py"),
local_pkg("dace", "external/dace"),
"mpi4py==3.1.5",
"mpi4py>=4.1",
"cftime",
"xarray>=2025.01.2", # datatree + fixes
"f90nml>=1.1.0",
Expand Down