Minor QOL changes to translate test infrastructure#176
Merged
Conversation
FlorianDeconinck
requested changes
Jun 27, 2025
Collaborator
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
Please had something in the README in ndsl/testing/README.md
Collaborator
|
Ping @oelbert for cross-review and awareness |
oelbert
reviewed
Aug 8, 2025
Collaborator
oelbert
left a comment
oelbert
left a comment
There was a problem hiding this comment.
I'm not sure what the warnings on the input/output data overrides are for. Are there specific issues we want to warn users of, or some edge cases that haven't been tested?
| ) | ||
| input_data = dataset_to_dict(out_data) | ||
| ndsl_log.warning( | ||
| f"You are loading {case.testobj.override_input_netcdf_name} as a custom input file! Here be dragons." |
Collaborator
There was a problem hiding this comment.
What is the warning for here? Are there specific issues users should be aware of?
Collaborator
Author
There was a problem hiding this comment.
Just to remind people that they are using non-standard options and to proceed with caution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor changes to test_translate.py:
Introduction of a new feature to override the default in/out netcdf names. Use:
self.override_input_netcdf_name = "FILE_NAME"andself.override_output_netcdf_name = "FILE_NAME". The new file must me in the same folder as the default file.Added a new error to prevent accidental overwrites of
self.outputs, which the translate test infrastructure expects to be unassigned.