tests: re-enable caching tests and more cleanups in tests/dsl#175
Merged
Conversation
Collaborator
|
Issue logged for cleanup of serial test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR looks at tests under
tests/dsland does some cleanup work. In particulartests_caches.py: They were skipped becauseMPIis always defined (since it's a non-optional import)tests_caches.py: Tests haven't been running since we moved away from python 3.8 (because the python version was hard-coded in there ...)make_storageinto a utility module (used from two test modules)tests/dsl/test_stencil_factory.pywith more than one backendJust to disambiguate: Some tests (the ones inside
tests/mpi) rely onMPIbeing changed toNonein case of a serial run:NDSL/tests/mpi/mpi_comm.py
Lines 1 to 6 in 2986b45
Tests outside
test/mpiimportMPIfrommpi4pydirectly and thus check the world size themselves. Might be worth cleaning this up anyway ... or - you know - usepytest.markerinstead. Feel free to leave this open if you want to discuss this.How Has This Been Tested?
Running tests locally.
Checklist: