Skip to content

Update pre-commit hooks#172

Merged
romanc merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/pre-commit-update
Jun 23, 2025
Merged

Update pre-commit hooks#172
romanc merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/pre-commit-update

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Jun 23, 2025

Description

This PR updates pre-commit tools to newer versions. Some defaults changed in the black formatter, which affects the styling of a couple files.

How Has This Been Tested?

Running pre-commit locally (and on the CI).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code: N/A
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

Comment thread ndsl/dsl/dace/orchestration.py
@romanc romanc marked this pull request as ready for review June 23, 2025 13:20
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks decent - thanks for doing this we were falling behind

@romanc romanc merged commit 2986b45 into NOAA-GFDL:develop Jun 23, 2025
5 checks passed
@romanc romanc deleted the romanc/pre-commit-update branch June 23, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants