WIP: zarr tests revival#156
Closed
romanc wants to merge 2 commits into
Closed
Conversation
This was referenced May 28, 2025
`cupy` and `zarr` are optional dependencies that developers needed to install manually into the environment if desired. This commit allows to install NDSL with the `cupy` and/or `zarr` extra.
romanc
force-pushed
the
romanc/zarr-test-revival
branch
from
381e314 to
2cdbad8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cupyandzarrare optional dependencies, which developers needed to install by hand. This PR proposes to add separate extras for these two dependencies. This allows to run tests with and withoutzarrinstalled (in parallel).Most of
zarrtests are failing. Not worth to fix now. Let's put them on the pile for later as mentioned/argued in issue #157.