tests: Don't exit on first failure#155
Merged
FlorianDeconinck merged 1 commit intoMay 28, 2025
Merged
Conversation
Collaborator
|
Longer feedback from the CI but we don't really code against it at the moment, so I don't mind. Will let NOAA go in. |
fmalatino
approved these changes
May 28, 2025
Contributor
fmalatino
left a comment
There was a problem hiding this comment.
Agreed. We were a little too cautious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests currently exist as soon as one test fails. Other tests don't even run. Imo this doesn't make sense on the CI. I'd rather see all the failing tests at once.
How Has This Been Tested?
As part of PR #154, which had failing tests.
Checklist: