Skip to content

tests: Don't exit on first failure#155

Merged
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/tests-dont-fail-fast
May 28, 2025
Merged

tests: Don't exit on first failure#155
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/tests-dont-fail-fast

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented May 28, 2025

Description

Tests currently exist as soon as one test fails. Other tests don't even run. Imo this doesn't make sense on the CI. I'd rather see all the failing tests at once.

How Has This Been Tested?

As part of PR #154, which had failing tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

Longer feedback from the CI but we don't really code against it at the moment, so I don't mind. Will let NOAA go in.

Copy link
Copy Markdown
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. We were a little too cautious.

@FlorianDeconinck FlorianDeconinck merged commit b5f6e5a into NOAA-GFDL:develop May 28, 2025
5 checks passed
@romanc romanc deleted the romanc/tests-dont-fail-fast branch May 28, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants