Skip to content

Change gt4py imports in examples and tests#148

Merged
FlorianDeconinck merged 3 commits into
NOAA-GFDL:developfrom
romanc:romanc/examples-fix-gt4py-import
May 27, 2025
Merged

Change gt4py imports in examples and tests#148
FlorianDeconinck merged 3 commits into
NOAA-GFDL:developfrom
romanc:romanc/examples-fix-gt4py-import

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented May 27, 2025

Description

This is a follow-up from #126. In this PR, we update the import paths in examples and tests to pull gt4py-related concepts from ndsl.dsl.gt4py.

Since we import from ndsl.dsl.gt4py in tests now, we actually don't need a separate test file for that and can thus safely delete tests/dsl/gt4py/test_gt4py_wrapper.py.

How Has This Been Tested?

I ran the notebooks locally. Tests are run by CI.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

@romanc romanc changed the title Fxi gt4py imports in examples and tests Change gt4py imports in examples and tests May 27, 2025
@romanc romanc mentioned this pull request May 27, 2025
7 tasks
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit 357c67d into NOAA-GFDL:develop May 27, 2025
5 checks passed
@romanc romanc deleted the romanc/examples-fix-gt4py-import branch May 27, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants