Quantity.field has true array accessor to the compute domain on a Quantity#141
Merged
FlorianDeconinck merged 9 commits intoMay 13, 2025
Merged
Conversation
Rename `data_array` as `data_as_xarray` and introduce `field_as_xarray`
oelbert
previously approved these changes
May 12, 2025
Collaborator
oelbert
left a comment
oelbert
left a comment
There was a problem hiding this comment.
v happy to see this go in
Comment on lines
97
to
99
| assert quantity.data[0, 0] == 1 | ||
| assert quantity.data[2, 2] == 5 | ||
| assert quantity.data[4, 4] == 3 |
Collaborator
There was a problem hiding this comment.
Maybe someday it will make sense to do this with a halo and we can test that the data is different than the field or view
Collaborator
Author
There was a problem hiding this comment.
Your wishes are my command*.
*Subject to budget constraint, time and implementation technical details. Offer can be removed at any time for no reasons. Definition of "wishes" and "command" subject to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fieldas a replacement forquantity.view[:]data_arrayasdata_as_xarrayand introducefield_as_xarrayHow Has This Been Tested?
Extension to the unit tests
Checklist: