Ochestration with ConstantPropagation#139
Merged
romanc merged 3 commits intoMay 9, 2025
Merged
Conversation
ConstantPropagation is part of the standard simplification pipeline. It was previously skipped because of an issue. In the meantime, that issue was resolved and we can propagate constats again.
FlorianDeconinck
approved these changes
May 9, 2025
Collaborator
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
I am worried. But we should. But I am worried. Let's do it. Worried. Yeah.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConstantPropagationis part of the standard simplification pipeline. It was previously skipped because of an issue. In the meantime, that issue was resolved and we can propagate constants again.Fixes GEOS-ESM#68
How Has This Been Tested?
Locally, I ran the following PyFV3 translate tests (in dace:orchestration mode) with this change:
FvTp2dD_SWRemappingFVDynamics(the dycore, mpi-test with 6 threads)DynCore("accoustics", mpi-test with 6 threads)Checklist: