Skip to content

Features used in the shallow convection and the PBL schemes#130

Merged
FlorianDeconinck merged 16 commits into
NOAA-GFDL:developfrom
oelbert:feature/shalconv
May 16, 2025
Merged

Features used in the shallow convection and the PBL schemes#130
FlorianDeconinck merged 16 commits into
NOAA-GFDL:developfrom
oelbert:feature/shalconv

Conversation

@oelbert
Copy link
Copy Markdown
Collaborator

@oelbert oelbert commented Apr 10, 2025

Description
This PR adds some namelist parameters for the shallow convection and pbl schemes, as well as some quality of life features for development, namely a "k_select" stencil that is the equivalent of selecting a 2d slice of a 3d field where hte k-index differs for each i and j value, as well as adding the "index_variable" flag for translate tests, for when your test data includes a k-index as a test variable.

How Has This Been Tested?
The shallow convection and pbl scheme translate tests are all run using this branch now

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@oelbert oelbert marked this pull request as draft April 10, 2025 20:58
bensonr
bensonr previously approved these changes Apr 11, 2025
@bensonr bensonr self-requested a review April 11, 2025 13:24
@oelbert oelbert marked this pull request as ready for review April 25, 2025 16:07
Comment thread ndsl/stencils/basic_operations.py
Comment thread ndsl/namelist.py Outdated
@oelbert oelbert requested a review from FlorianDeconinck May 16, 2025 15:08
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit 7e152ce into NOAA-GFDL:develop May 16, 2025
5 checks passed
@oelbert oelbert deleted the feature/shalconv branch August 14, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants