Features used in the shallow convection and the PBL schemes#130
Merged
Conversation
bensonr
previously approved these changes
Apr 11, 2025
FlorianDeconinck
requested changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some namelist parameters for the shallow convection and pbl schemes, as well as some quality of life features for development, namely a "k_select" stencil that is the equivalent of selecting a 2d slice of a 3d field where hte k-index differs for each i and j value, as well as adding the "index_variable" flag for translate tests, for when your test data includes a k-index as a test variable.
How Has This Been Tested?
The shallow convection and pbl scheme translate tests are all run using this branch now
Checklist: