Skip to content

Fix saving NetCDF for parallel translate test #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianDeconinck merged 1 commit into from
Mar 31, 2025
Merged

Fix saving NetCDF for parallel translate test #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ndsl/stencils/testing/test_translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,14 +407,15 @@ def test_parallel_savepoint(
input_data_on_host[key] = gt_utils.asarray(_input)
save_netcdf(
case.testobj,
[input_data_on_host],
[output],
ref_data,
failing_names,
nct_filename,
inputs_list=[input_data_on_host],
output_list=[output],
ref_data=ref_data,
failing_names=failing_names,
passing_names=passing_names,
out_filename=nct_filename,
)
except Exception as error:
print(f"TestParallel SaveNetCDF Error: {error}")
print(f"TestParallel SaveNetCDF Error at rank {case.grid.rank}: {error}")
if failing_names != []:
pytest.fail(
f"Only the following variables passed: {passing_names}", pytrace=False
Expand Down Expand Up @@ -460,7 +461,7 @@ def _save_datatree(
data_vars = {}
varname = names[index]
# Read in dimensions and attributes
if hasattr(testobj, "outputs"):
if hasattr(testobj, "outputs") and testobj.outputs != {}:
dims = [
dim_name + f"_{index}" for dim_name in testobj.outputs[varname]["dims"]
]
Expand Down