Fix for ice-shelf friction velocity bugs#995
Conversation
alex-huth
force-pushed
the
IS_fricvel_devgfdl
branch
from
2440363 to
4731991
Compare
Hallberg-NOAA
added
bug
|
@Hallberg-NOAA I ended up removing the |
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This simpler PR looks to me like it is ready to go.
I would note that this corrects an obvious symmetry-breaking bug that will change answers in some cases with an ice shelf using USTAR_SHELF_FROM_VEL = True without adding a bug-fix flag. I do not think that such configurations are widely used (or else the symmetry breaking should have been detected earlier), so this may be a case where no bug recovery option is needed, but we might come to regret this decision later.
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Upon further reflection, Alex and I decided that we should probably follow the standard MOM6 process and add a runtime bug-fix flag around the code correcting this bug, so that answers are not changed by default.
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This final change addresses all the concerns I had previously.
Hallberg-NOAA
added
Parameter change
Fixed an incorrect area used to calculate cell-centered ocean surface velocity under the ice_shelf, which can impact the calculation of ice-shelf friction velocity. Added missing flags to some allocate_surface_state calls so that sfc_state%taux_shelf and sfc_state%tauy_shelf are allocated. This is required for the surface-stress-based (rather than surface-velocity-based) calculation of ice-shelf friction velocity. Also added taux_shelf and tauy_shelf as diagnostics for the surface stress under the ice shelf.
… ocean velocity bug
Hallberg-NOAA
force-pushed
the
IS_fricvel_devgfdl
branch
from
cc729d3 to
1d07659
Compare
|
This PR passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/29558. |
2 participants
Fixed an incorrect area used to calculate cell-centered ocean surface velocity under the ice shelf, which can impact the calculation of ice-shelf friction velocity. Added missing flags to some
allocate_surface_statecalls so thatsfc_state%taux_shelfandsfc_state%tauy_shelfare allocated. This is required for the surface-stress-based (rather than surface-velocity-based) calculation of ice-shelf friction velocity. Also addedtaux_shelfandtauy_shelfas diagnostics for the ocean surface stress under the ice shelf.