+Correct halo update sizes and reduce halo updates#969
Merged
Hallberg-NOAA merged 2 commits intoSep 18, 2025
Conversation
Added the new argument dyn_h_stencil to initialize_dyn_split_RK2 and the other 3 dynamic core initialization routines to return the size of the stencil for thicknesses as used by the dynamic core, depending on the options that are being used for the Coriolis and continuity schemes, and then used this in a set of halo updates in step_MOM_dynamics. With this change some additional halo updates that have recently been added inside of step_MOM_dyn_split_RK2 and the other 3 dynamic core time stepping routines could be eliminated. All answers are bitwise identical, but there is a new argument to 4 public interfaces.
Hallberg-NOAA
added
the
refactor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #969 +/- ##
============================================
+ Coverage 37.41% 37.42% +0.01%
============================================
Files 304 304
Lines 93061 93043 -18
Branches 17860 17852 -8
============================================
+ Hits 34816 34819 +3
+ Misses 51678 51665 -13
+ Partials 6567 6559 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marshallward
approved these changes
Sep 15, 2025
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/28871. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the new argument
dyn_h_stenciltoinitialize_dyn_split_RK2()and the other 3 dynamic core initialization routines to return the size of the stencil for thicknesses as used by the dynamic core, depending on the options that are being used for the Coriolis and continuity schemes, and then used this in a set of halo updates instep_MOM_dynamics(). With this change some additional halo updates that have recently been added inside ofstep_MOM_dyn_split_RK2()and the other 3 dynamic core time stepping routines could be (and were) eliminated. All answers are bitwise identical, but there is a new argument to 4 public interfaces.