add residual loss term for internal tides#95
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #95 +/- ##
============================================
- Coverage 28.99% 28.98% -0.02%
============================================
Files 246 246
Lines 72304 72348 +44
============================================
Hits 20967 20967
- Misses 51337 51381 +44
Continue to review full report at Codecov.
|
Member
|
Just a reminder that this has outstanding |
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15104 ✔️ |
marshallward
approved these changes
Mar 31, 2022
This was referenced May 16, 2022
marshallward
pushed a commit
that referenced
this pull request
Sep 12, 2022
update to main branch 20220629 commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this term uses the residual from the reflection/transmission coefficients to compute the energy loss due to scattering to higher modes on the slopes. Replacement for PR #33 with clean history