Skip to content

*Implement sub-cycling for internal tides refraction/propagation#913

Merged
Hallberg-NOAA merged 7 commits into
NOAA-GFDL:dev/gfdlfrom
raphaeldussin:subcycle_inttides
Jun 12, 2025
Merged

*Implement sub-cycling for internal tides refraction/propagation#913
Hallberg-NOAA merged 7 commits into
NOAA-GFDL:dev/gfdlfrom
raphaeldussin:subcycle_inttides

Conversation

@raphaeldussin
Copy link
Copy Markdown

This PR allows to bring back the thermodynamics timestep higher while keeping the raytracing under CFL by doing multiple steps within the thermo step.

The only variable that needs to be accumulated in the subcycling is the slope loss (residual of transmission and reflection on slopes) Since it is already accumulated within the 2 directions of propagation, it only needs to be initialized outside of the subcycling.

raphaeldussin and others added 3 commits June 3, 2025 11:02
This PR allows to bring back the thermodynamics timestep higher
while keeping the raytracing under CFL by doing multiple steps
within the thermo step.

The only variable that needs to be accumulated in the subcycling
is the slope loss (residual of transmission and reflection on slopes)
Since it is already accumulated within the 2 directions of propagation,
it only needs to be initialized outside of the subcycling.
@raphaeldussin
Copy link
Copy Markdown
Author

my quick and dirty testing (2 days of OM4) shows we were able to come back to DT_THERM = 7200 from 3600 with INTERNAL_TIDE_SUBCYCLING = 2 and the timing for the "Ocean thermodynamics and tracers" is down from 57s to 32s (consistent with doing only half the work) compared to 28s for a run without the parameterization and DT_THERM = 7200

@raphaeldussin raphaeldussin marked this pull request as ready for review June 11, 2025 03:05
@raphaeldussin
Copy link
Copy Markdown
Author

I was able to reproduce previous answers with DT_THERM = DT_ITIDES = 3600 and reproduces across processor counts.

Comment thread src/parameterizations/lateral/MOM_internal_tides.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_internal_tides.F90 Outdated
Copy link
Copy Markdown
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes now look good to me. Thank you for the addition of this valuable new capability that will make the internal tides code much more efficient and make it practical to
use them in GFDL's Earth system models.

@Hallberg-NOAA Hallberg-NOAA added enhancement New feature or request Parameter change Input parameter changes (addition, removal, or description) labels Jun 12, 2025
@Hallberg-NOAA
Copy link
Copy Markdown
Member

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/27743. I would have expected there to be changes in runtime parameters, but there were not, which is telling us that we probably need to add the internal tides to one of the standard pipeline tests to give us coverage of this important new capability.

@Hallberg-NOAA Hallberg-NOAA merged commit 8df30d8 into NOAA-GFDL:dev/gfdl Jun 12, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Parameter change Input parameter changes (addition, removal, or description)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants