*Fix PE-count dependency with some kinds of OBCs#901
Merged
Hallberg-NOAA merged 1 commit intoMay 19, 2025
Conversation
Hallberg-NOAA
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #901 +/- ##
=========================================
Coverage 37.54% 37.55%
=========================================
Files 305 305
Lines 91434 91429 -5
Branches 17417 17415 -2
=========================================
Hits 34333 34333
+ Misses 50676 50673 -3
+ Partials 6425 6423 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hallberg-NOAA
force-pushed
the
fix_OBC_PE_count_dependency
branch
from
c783293 to
b80dce7
Compare
theresa-cordero
approved these changes
May 19, 2025
Fixed a bug that was causing some open boundary condition fields (e.g., those related to the tides) not to be read in from files before they are used unless there are some PEs that do NOT include any input date based OBC points. This bug causes certain configurations with not to reproduce across PE count. Most high-PE count jobs (those with at least 3 PEs in each direction) previously were correct, but single PE jobs or jobs with a prime number or 2 times a prime number of PEs were never correct for these cases. Specifically, this commit removes the some_need_no_IO_for_data element from the ocean_OBC_type, and it always calls update_OBC_segment_data() during initialization when any OBCs are being used. It also replaces three calls to allocate_rotated_array() with calls to the new internal subroutine allocate_rotated_seg_data() to avoid a bug where the size of rotated data segments is right but the index range is wrong. This commit will change low-PE count answers for some cases with certain types of open boundary conditions.
Hallberg-NOAA
force-pushed
the
fix_OBC_PE_count_dependency
branch
from
b80dce7 to
d361e99
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/27477. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug that was causing some open boundary condition fields (e.g., those related to the tides) not to be read in from files before they are used unless there are some PEs that do NOT include any input date based OBC points. This bug causes certain configurations with not to reproduce across PE count. Most high-PE count jobs (those with at least 3 PEs in each direction) previously were correct, but single PE jobs or jobs with a prime number or 2 times a prime number of PEs were never correct for these cases. Specifically, this commit removes the
some_need_no_IO_for_dataelement from theocean_OBC_type, and it always callsupdate_OBC_segment_data()during initialization when any OBCs are being used. It also replaces three calls toallocate_rotated_array()with calls to the new internal subroutineallocate_rotated_seg_data()to avoid a bug where the size of rotated data segments is right but the index range is wrong. This commit will change low-PE count answers for some cases with certain types of open boundary conditions.