Glob unit tests#899
Merged
Merged
Conversation
Member
adcroft
commented
May 13, 2025
adcroft
commented
- Updates the build.coverage and run.coverage steps to use wildcards (to catch all tests rather than hard-coded lists)
- Renames run.timings to compare.timings and duplicates part back to run.timings
- run.timings is triggered on a push to check that the code does not break the timing drivers
- Renames mom6-unit-artifact to mom6-timing-artifact
- Enables mom6-timing-target-artifact (being tested in this PR)
adcroft
force-pushed
the
glob-unit-tests
branch
2 times, most recently
from
baa1a5b to
740ca34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #899 +/- ##
=========================================
Coverage 37.54% 37.55%
=========================================
Files 305 305
Lines 91434 91434
Branches 17417 17417
=========================================
+ Hits 34333 34335 +2
+ Misses 50676 50675 -1
+ Partials 6425 6424 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rather than explicitly list known unit tests, we now either wild card or use "find" to create a list.
- Using wild cards to catch all the drivers/timing/* executables - Run these tests on a push, but not to compare to target - Enabled artifacts for target opt executables - Had to re-clone target codebase in the compare-timings job - Also had to use the target_codebase/.testing/Makefile directly to avoid rebuilding executables
marshallward
approved these changes
May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.