Correct variable units in comments in 4 modules#894
Merged
Hallberg-NOAA merged 1 commit intoMay 3, 2025
Conversation
Hallberg-NOAA
added
the
refactor
Corrected the descriptions of the units of two I_rho variables in find_ustar_fluxes() and find_ustar_mech_forcing() and of the lensponge internal variable in RGC_initialize_sponges(). Also corrected the comments describing the locations of grid%geolatT and grid%geolonT. Also refactored dumbbell_initialize_thickness() to use geoLonT or geoLatT directly rather than setting a temporary variable with ill-defined units that is only used once. Only changes in comments or very simple code logic changes are included in this commit and all answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
corrected_comments
branch
from
33a324a to
4126225
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/27309. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the descriptions of the units of two
I_rhovariables infind_ustar_fluxes()andfind_ustar_mech_forcing()and of thelenspongeinternal variable inRGC_initialize_sponges(). Also corrected the comments describing the locations ofgrid%geolatTandgrid%geolonT. Also refactoreddumbbell_initialize_thickness()to usegeoLonTorgeoLatTdirectly rather than setting a temporary variable with ill-defined units that is only used once. Only changes in comments or very simple code logic changes are included in this commit, and all answers are bitwise identical.