Fix bugs in VBF diagnostics for tidal Kd terms#886
Merged
Conversation
breichl
commented
Apr 23, 2025
breichl
commented
- Kd_itides was not set for the VBF diagnostic because it mistakenly checked if Kd_itidal was associated. The check is updated. The note in the code to not confuse Kd_itides with Kd_itidal is confirmed.
- Code added to work with Polzin option in MOM_tidal_mixing
Hallberg-NOAA
approved these changes
Apr 23, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes only impact diagnostics, and upon visual inspection I agree that they are correct.
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/27231. |
marshallward
pushed a commit
that referenced
this pull request
Apr 28, 2025
* Fix bug in Kd_itides allocation check for VBF itides diagnostic * Set VBF tidal mixing outputs to work with Polzin option in addition to Simmons option --------- Co-authored-by: brandon.reichl <brandon.reichl@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.