User/wfc/nmme reproducibility 20250331#871
Merged
Hallberg-NOAA merged 5 commits intoJul 18, 2025
Merged
Conversation
marshallward
reviewed
Apr 8, 2025
Member
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
@wfcooke I added some suggested changes for this PR. Two are cosmetic, but I think the loop reorder relatively important.
Author
|
Updated to isolate the portion of the code that is changing NMME answers. |
Hallberg-NOAA
approved these changes
Jul 18, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Now that this commit has been revised to use the new runtime parameter REPRODUCE_2018_NMME_ANSWERS instead of a back-dated answer date, and also to address the more stylistic changes, it now looks acceptable to me. I am approving it pending successful pipeline testing.
Uses DEFAULT_ANSWER_DATE <20190101 to reproduce forecast results from older executable.
Will change logfiles due to new parameter (REPRODUCE_2018_NMME_ANSWERS) being added.
…haracters previously.
Hallberg-NOAA
force-pushed
the
user/wfc/NMME_reproducibility_20250331
branch
from
97d4d2b to
cf11505
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/28209. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to allow for reproducibility of older answers for NMME forecasts.
Using default_answer_date of >=20190101 will use the latest code.