Add variable dimensions to available_diags file#864
Conversation
|
Apologies for moving the goalposts, but if we're considering revisions to This would make postprocessing easier for many people. |
9baedf5 to
1efc7ed
Compare
Adds appropriate horizontal and vertical dimension names to the entries listed in the available_diags file. Scalar diagnostics are denoted with a "scalar" string.
1efc7ed to
75307c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #864 +/- ##
============================================
- Coverage 38.01% 36.79% -1.22%
============================================
Files 298 290 -8
Lines 87986 86927 -1059
Branches 16521 16524 +3
============================================
- Hits 33447 31989 -1458
- Misses 48483 48834 +351
- Partials 6056 6104 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Hallberg-NOAA - I reordered the dimensions and improved the string trimming logic as you suggested. |
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These proposed changes look good to me. Thank you for this valuable new contribution.
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26893 with the expected warnings about changes to the available diags file metadata. |
The output of the current
available_diagsfile lacks the dimensions of each diagnostic.This PR includes a commit that adds the appropriate horizontal and vertical dimension names to the entries listed in the available_diags file. Scalar diagnostics are denoted with a "scalar" string.
Example of an entry generated with the new code: