Expand error message when OBC files are missing#851
Merged
Hallberg-NOAA merged 3 commits intoMar 12, 2025
Conversation
added 3 commits
March 11, 2025 09:57
Add a check if the OBC file exists and give a fatal error if not.
Author
|
After discussing with @Hallberg-NOAA it was suggested that I change this to an explicit check if the file exists and then give an error if not. Note this is already within a check that a filename does exist and therefore should not cause a crash for set ups where OBC's are used but file names are not required. |
Hallberg-NOAA
approved these changes
Mar 12, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree that this added error message should be much more informative than its predecessor.
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26712. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CEFI-regional-MOM6 issue 154
The current error message when an OBC file name is incorrect or the file is missing is not clear. This PR adds to the existing error message to give two more possible reasons the error may be triggered.