Correct indenting in ePBL_column#836
Merged
Hallberg-NOAA merged 1 commit intoFeb 19, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #836 +/- ##
=========================================
Coverage 38.10% 38.10%
=========================================
Files 298 298
Lines 87644 87644
Branches 16418 16418
=========================================
Hits 33400 33400
Misses 48226 48226
Partials 6018 6018 ☔ View full report in Codecov by Sentry. |
marshallward
approved these changes
Feb 19, 2025
Member
marshallward
left a comment
There was a problem hiding this comment.
I agree with the indentation change, and overall the style was otherwise preserved.
Corrected the indenting in most of the lines of ePBL_column to respect the MOM6 2-space indenting convention, and eliminated the comment explaining why the incorrect indenting had previously been retained to facilitate the review of a pull request with substantial actual changes in this routine. Apart from a single comment that was removed, only white space is changed, and all answers are bitwise identical.
8f7ebe2 to
a62ab03
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26445. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the indenting in most of the lines of ePBL_column to respect the MOM6 2-space indenting convention, and eliminated the comment explaining why the incorrect indenting had previously been retained to facilitate the review of a pull request with substantial actual changes in this routine. Apart from a single comment that was removed, only white space is changed, and all answers are bitwise identical.
(When reviewing the code changes in this pull request, I recommend the use of the "Hide whitespace" setting!)