Add option to use BT_CONT to calculate dtbt#823
Merged
Conversation
Hallberg-NOAA
requested changes
Feb 3, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Overall, these changes make sense to me, including the reordering of the optional arguments to set_dtbt (which is something we would usually discourage). However, there are some very minor changes that I would like to see to the declaration lines for CS%dtbt_use_bt_cont (detailed separately in a specific comment) before this PR should be merged into dev/gfdl.
herrwang0
force-pushed
the
fix_setdtbt
branch
from
1abc34b to
97303e8
Compare
Hallberg-NOAA
approved these changes
Feb 13, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This PR looks to me like it has been properly implemented and is ready to be merged in.
Change the order of optional input arguments of subroutine set_dtbt so that they are grouped logically. The decription of the subroutine is also updated.
The runtime parameter allows to use BT_CONT optional input argument in subroutine set_dtbt if BT_CONT type is available. Originally, when BT_CONT is used, set_dtbt is estimated with zero surface height. The eta optinoal input argument has no effect since it only works with NONLINEAR_BT_CONTINUITY is true, which is by default false when BT_CONT is used. The added option allows accurate estimate of dtbt when the mean surface height of the domain is not at the same level, while maintains old answers. Also, an unused field calc_dtbt in type MOM_dyn_split_RK2_CS is removed.
* Fix a bug that local variable calc_dtbt is not initialized. * Rename dtbt_tmp to dtbt_restart for clarity * Add a comment about the usage of subroutine call set_dtbt * Remove an unused input argument eta in barotropic_init
Hallberg-NOAA
force-pushed
the
fix_setdtbt
branch
from
97303e8 to
bd9e9fa
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26378 with the expected warnings about a new runtime parameter in MOM_parameter_doc files. |
kshedstrom
pushed a commit
to ESMG/MOM6
that referenced
this pull request
Mar 17, 2025
* Reorder optional input arguments in set_dtbt Change the order of optional input arguments of subroutine set_dtbt so that they are grouped logically. The decription of the subroutine is also updated. * Add runtime parameter SET_DTBT_USE_BT_CONT The runtime parameter allows to use BT_CONT optional input argument in subroutine set_dtbt if BT_CONT type is available. Originally, when BT_CONT is used, set_dtbt is estimated with zero surface height. The eta optinoal input argument has no effect since it only works with NONLINEAR_BT_CONTINUITY is true, which is by default false when BT_CONT is used. The added option allows accurate estimate of dtbt when the mean surface height of the domain is not at the same level, while maintains old answers. Also, an unused field calc_dtbt in type MOM_dyn_split_RK2_CS is removed. * Minor fixes on setting dtbt in barotropic_init * Fix a bug that local variable calc_dtbt is not initialized. * Rename dtbt_tmp to dtbt_restart for clarity * Add a comment about the usage of subroutine call set_dtbt * Remove an unused input argument eta in barotropic_init
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR recovers an option to use BT_CONT to calculate
dtbtin subroutineset_dtbtby adding a new runtime parameterSET_DTBT_USE_BT_CONT. The option to use BT_CONT inset_dtbtpreviously exists but is never used.Currently, when
USE_BT_CONT_TYPEis true (default), dtbt is effectively calculated using topography (i.e. with zero sea surface height). For example,etain the following call is never used as its usage requiresNONLINEAR_BT_CONTINUITYis true, which is by default false withUSE_BT_CONT_TYPE=True.MOM6/src/core/MOM_dynamics_split_RK2.F90
Line 651 in cbb8bfa
With the old setup, the model fails to correctly estimate
dtbtwhen the domain has an uneven mean surface height like the Great Lakes system.This PR provides a fix to issue #660.
This PR also modifies the interface of subroutine
set_dtbtfor better readability.There is no answer change but a new runtime parameter is added.