Passing shelf_sfc_mass_flux to ice shelf#818
Merged
Merged
Conversation
Hallberg-NOAA
requested changes
Jan 31, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
There are a few issues that I would to see addressed before we could merge in this useful new field.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #818 +/- ##
============================================
+ Coverage 38.15% 38.17% +0.01%
============================================
Files 296 296
Lines 87254 87471 +217
Branches 16288 16389 +101
============================================
+ Hits 33296 33388 +92
- Misses 47971 48076 +105
- Partials 5987 6007 +20 ☔ View full report in Codecov by Sentry. |
Hallberg-NOAA
approved these changes
Feb 13, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I am convinced that this updated PR is correctly implemented.
* Removed second registration of sfc_mass_flux with register_diag_field. * Registered sfc_mass_flux to runs with static and dynamic ice sheets.
…gister_diag_field()'
…added back and 'register_restart_field()' of 'fluxes_in%shelf_sfc_mass_flux' is moved before 'restore_state()'
OlgaSergienko
force-pushed
the
dev/cryo
branch
from
9ad5539 to
2f06732
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26435. |
kshedstrom
pushed a commit
to ESMG/MOM6
that referenced
this pull request
Mar 17, 2025
* Commit for coupling of land to ocean adot * Remove unused ice sheet enabled flag * add adot to Shelf restart * Register sfc mass flux outside of initialize fluxes * Gfdl cryo merge (NOAA-GFDL#3) * Removed second registration of sfc_mass_flux with register_diag_field. * Registered sfc_mass_flux to runs with static and dynamic ice sheets. * This commit removed the second registration of 'sfc_mass_flux' in 'register_diag_field()' * Testing shelf_sfc_mass_flux restart. * The earlier removed 'register_diag_field()' for 'mass_flux' has been added back and 'register_restart_field()' of 'fluxes_in%shelf_sfc_mass_flux' is moved before 'restore_state()' * Corrected the line length error. * Added back 'CS%id_mass_flux = register_diag_field()' --------- Co-authored-by: NJSchlegel <nschlegel@gmail.com>
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR from gfdl-cryopshere group. It includes several changes related to the surface mass flux from the land to the ice sheet,
shelf_sfc_mass_flux. It is now defined in MOM_surface_forcing_gfdl.F90 and its values are passed tofluxes%shelf_sfc_mass_flux. This field can be used in configurations with a static ice sheet. To accommodate that it is now registered as a diagnostic field withCS%active_shelf_dynamics=.false..