+Remove dyn_horgrid_type%Rad_Earth and ocean_grid_type%Rad_Earth#769
Merged
Hallberg-NOAA merged 1 commit intoJan 16, 2025
Merged
Conversation
Hallberg-NOAA
added
the
refactor
theresa-cordero
approved these changes
Jan 15, 2025
theresa-cordero
left a comment
theresa-cordero
left a comment
There was a problem hiding this comment.
Approved. I suggest we open an issue or a similar PR to SIS2 to remove Rad_Earth there as well.
Member
Author
|
There is no need for the equivalent PR on SIS2 because G%Rad_Earth was already removed from the SIS2 code on December 23, 2021! |
marshallward
approved these changes
Jan 16, 2025
Remove the unused element Rad_Earth from ocean_grid_type and dyn_horgrid_type. The dimensionally rescaled equivalent element G%Rad_Earth_L is extensively used, and it will continue to exist. G%Rad_Earth_L was introduced in November 27, 2021 as a dimensionally rescaled version of G%Rad_Earth, while the unscaled version was retained because at the time, the Rad_Earth element of the dyn_horgrid_type is also used in SIS2. However, SIS2 has not used G%Rad_Earth since December 23, 2021, so after 3 years we can now safely remove this unused element. Any cases on other branches that might be impacted by this change will not compile. All answers are bitwise identical, but there is one less element in two transparent types.
Hallberg-NOAA
force-pushed
the
remove_G_Rad_Earth
branch
from
67dd232 to
3c8dfd7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #769 +/- ##
============================================
- Coverage 38.15% 38.15% -0.01%
============================================
Files 296 296
Lines 87217 87215 -2
Branches 16280 16280
============================================
- Hits 33278 33277 -1
+ Misses 47953 47952 -1
Partials 5986 5986 ☔ View full report in Codecov by Sentry. |
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26095. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused element
Rad_Earthfromocean_grid_typeanddyn_horgrid_type. The dimensionally rescaled equivalent elementG%Rad_Earth_Lis extensively used, and it will continue to exist.G%Rad_Earth_Lwas introduced in November 27, 2021 as a dimensionally rescaled version ofG%Rad_Earth, while the unscaled version was retained because at the time, theRad_Earthelement of thedyn_horgrid_typeis also used in SIS2. However, SIS2 has not usedG%Rad_Earthsince December 23, 2021, so after 3 years we can now safely remove this unused element.Any cases on other branches that might be impacted by this change will not compile. All answers are bitwise identical, but there is one less element in two transparent types.