Fix bugs in setting GxSpV_u and GxSpV_v in MOM_isopycnal_slopes#701
Merged
Conversation
Wendazhang33
commented
Jul 31, 2024
Wendazhang33
commented
- In the previous version, GxSpV_u and GxSpV_v were only set when use_EOS was true
- Now initialize GxSpV_u and GxSpV_v to be G_Rho0
Wendazhang33
force-pushed
the
GxSpV_fix
branch
2 times, most recently
from
cc14f9e to
828e1a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #701 +/- ##
============================================
- Coverage 36.99% 35.87% -1.13%
============================================
Files 272 269 -3
Lines 82438 81375 -1063
Branches 15421 15406 -15
============================================
- Hits 30500 29195 -1305
- Misses 46246 46438 +192
- Partials 5692 5742 +50 ☔ View full report in Codecov by Sentry. |
Hallberg-NOAA
approved these changes
Aug 2, 2024
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree that these changes are correct and necessary.
- In the previous version, GxSpV_u and GxSpV_v were only set when use_EOS was true - Now initialize GxSpV_u and GxSpV_v to be G_Rho0
Hallberg-NOAA
force-pushed
the
GxSpV_fix
branch
from
63003da to
8356e93
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24333. |
This was referenced Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.