(*)+Restore USE_WRIGHT_2ND_DERIV_BUG functionality#686
Merged
adcroft merged 1 commit intoJul 17, 2024
Merged
Conversation
This commit restores the effectiveness of the runtime parameter USE_WRIGHT_2ND_DERIV_BUG in determining whether a bug is corrected in the calculation of two of the second derivative terms returned by calculate_density_second_derivs_elem() with the "WRIGHT" equation of state, recreating the behavior (and answers) that are currently on the main branch of MOM6. To do this, it adds and calls the new routine set_params_buggy_Wright() when appropriate, and adds the new element "three" to the buggy_Wright_EOS type. When the bug is fixed, buggy_Wright_EOS%three = 3, but ...%three = 2 to recreate the bug. This commit does change answers for cases using the "WRIGHT" equation of state and one of the "USE_STANLEY_..." parameterizations from those on the dev/gfdl branch of MOM6, but in so doing it restores the answers on the main branch of MOM6. There is also a new publicly visible subroutine.
|
This PR fixes the baseline comparison failures for all but one CESM test: All of the tests using our workhorse configuration are now passing, but a quarter-degree test is failing the bitwise reproducibility test. The failing test configuration was initially based on GFDL's quarter-degree setup, with some changes over time. Note, however, that changing |
Member
Author
|
This has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24117. Because that test is comparing MOM_parameter_doc files with the results from dev/gfdl, it is falsely reporting parameter changes, but the answers are bitwise identical. |
adcroft
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit restores the effectiveness of the runtime parameter
USE_WRIGHT_2ND_DERIV_BUGin determining whether a bug is corrected in the calculation of two of the second derivative terms returned bycalculate_density_second_derivs_elem()with the "WRIGHT" equation of state, recreating the behavior (and answers) that are currently on the main branch of MOM6. To do this, it adds and calls the new routineset_params_buggy_Wright()when appropriate, and adds the new element "three" to thebuggy_Wright_EOStype. When the bug is fixed,buggy_Wright_EOS%three = 3, but...%three = 2to recreate the bug. This commit does change answers for cases using the "WRIGHT" equation of state and one of the "USE_STANLEY_..." parameterizations from those on the dev/gfdl branch of MOM6, but in so doing it restores the answers on the main branch of MOM6. There is also a new publicly visible subroutine.