Bugfix for tracer advection diagnostic in symmetric memory mode#649
Merged
marshallward merged 1 commit intoMay 24, 2024
Merged
Conversation
breichl
commented
May 23, 2024
breichl
commented
- Fix logic so tracer advection diagnostics are computed correctly for symmetric memory mode
- Addresses Issue Broken diagnostics (T_adx, T_ady, S_adx, S_ady) in symmetric memory mode #646
- Fix logic so tracer advection diagnostics are computed correctly for symmetric memory mode
Hallberg-NOAA
approved these changes
May 24, 2024
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree that these changes are correct. However, I think that it would be helpful for there to be a future investigation into whether it is helpful to have the if (do_i(...)) then tests at all for these advective flux diagnostics.
Member
|
This needs to be cherry-picked into gfdl-to-main-2024-05-21 after it is merged into dev/gfdl. |
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/23584 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.