Skip to content

SAL: Explicitly allocate sht variable in SAL_CS #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marshallward merged 3 commits into from
May 14, 2024
Merged

SAL: Explicitly allocate sht variable in SAL_CS #627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22329ca
SAL: Explicitly allocate sht variable in SAL_CS
marshallward May 10, 2024
7cbdca1
Merge branch 'dev/gfdl' into SAL_sht_to_heap
adcroft May 13, 2024
194dcb7
Merge branch 'dev/gfdl' into SAL_sht_to_heap
marshallward May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/parameterizations/lateral/MOM_self_attr_load.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,17 @@ module MOM_self_attr_load

!> The control structure for the MOM_self_attr_load module
type, public :: SAL_CS ; private
logical :: use_sal_scalar !< If true, use the scalar approximation to calculate SAL.
logical :: use_sal_sht !< If true, use online spherical harmonics to calculate SAL
logical :: use_tidal_sal_prev !< If true, read the tidal SAL from the previous iteration of
!! the tides to facilitate convergence.
logical :: use_sal_scalar = .false.
!< If true, use the scalar approximation to calculate SAL.
logical :: use_sal_sht = .false.
!< If true, use online spherical harmonics to calculate SAL
logical :: use_tidal_sal_prev = .false.
!< If true, read the tidal SAL from the previous iteration of the tides to
!! facilitate convergence.
real :: sal_scalar_value !< The constant of proportionality between sea surface height
!! (really it should be bottom pressure) anomalies and bottom
!! geopotential anomalies [nondim].
type(sht_CS) :: sht !< Spherical harmonic transforms (SHT) control structure
type(sht_CS), allocatable :: sht !< Spherical harmonic transforms (SHT) control structure
integer :: sal_sht_Nd !< Maximum degree for SHT [nodim]
real, allocatable :: Love_Scaling(:) !< Love number for each SHT mode [nodim]
real, allocatable :: Snm_Re(:), & !< Real SHT coefficient for SHT SAL [Z ~> m]
Expand Down Expand Up @@ -218,6 +221,8 @@ subroutine SAL_init(G, US, param_file, CS)

allocate(CS%Love_Scaling(lmax)); CS%Love_Scaling(:) = 0.0
call calc_love_scaling(CS%sal_sht_Nd, rhoW, rhoE, CS%Love_Scaling)

allocate(CS%sht)
call spherical_harmonics_init(G, param_file, CS%sht)
endif

Expand All @@ -234,6 +239,7 @@ subroutine SAL_end(CS)
if (allocated(CS%Snm_Re)) deallocate(CS%Snm_Re)
if (allocated(CS%Snm_Im)) deallocate(CS%Snm_Im)
call spherical_harmonics_end(CS%sht)
deallocate(CS%sht)
endif
end subroutine SAL_end

Expand Down