+Fix multiple bugs when MEKE_GM_SRC_ALT is True#620
Merged
marshallward merged 2 commits intoMay 8, 2024
Conversation
Fix several bugs when MEKE_GM_SRC_ALT is True, including corrections to two dimensional rescaling factors, and optionally fix a bug that sets a limit only on positive slopes but leaving negative slopes unlimited. This bug is corrected when the new runtime parameter MEKE_GM_SRC_ALT_SLOPE_BUG is false. Additionally there is a new runtime parameter MEKE_GM_SRC_ANSWER_DATE that specifies the use of rotationally symmetric expressions for PE_release_h when it is set to 20240601 or higher, but it should be noted that rotational symmetry also requires that MEKE_GM_SRC_ALT_SLOPE_BUG is false. Four new checksum calls were also added to verify the correctness of the calculation of MEKE%GM_src when MEKE_GM_SRC_ALT and DEBUG are true. By default, all answers are bitwise identical but there are two new runtime parameters in some MOM_parameter_doc files.
Hallberg-NOAA
added
bug
This was referenced May 5, 2024
Member
Author
marshallward
approved these changes
May 7, 2024
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/23385 ✔️ |
This was referenced May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several bugs when
MEKE_GM_SRC_ALTis True, including corrections to two dimensional rescaling factors, and optionally fix a bug that sets a limit only on positive slopes but leaving negative slopes unlimited. This bug is corrected when the new runtime parameterMEKE_GM_SRC_ALT_SLOPE_BUGis false. Additionally there is a new runtime parameterMEKE_GM_SRC_ANSWER_DATEthat specifies the use of rotationally symmetric expressions forPE_release_hwhen it is set to 20240601 or higher, but it should be noted that rotational symmetry also requires thatMEKE_GM_SRC_ALT_SLOPE_BUGis false. Four new checksum calls were also added to verify the correctness of the calculation ofMEKE%GM_srcwhenMEKE_GM_SRC_ALTandDEBUGare true. By default, all answers are bitwise identical but there are two new runtime parameters in some MOM_parameter_doc files.