(*)Revise 13 diagnostics for rotational symmetry

[Hallberg-NOAA]

Refactored 10 diagnostics related to terms in the kinetic energy budgets and 2 diagnostics of nonlinear relative-vorticity related accelerations to respect rotational symmetry. These diagnostics are mathematically equivalent but will change at roundoff due to changes in the order of arithmetic. Only diagnostics are changed, and the solutions themselves are bitwise identical in all cases.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.07%. Comparing base (46fd6e6) to head (d3456bc).

❗ Current head d3456bc differs from pull request most recent head 0b582be. Consider uploading reports for the commit 0b582be to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           dev/gfdl     #605      +/-   ##
============================================
+ Coverage     37.02%   37.07%   +0.05%     
============================================
  Files           271      271              
  Lines         81109    80975     -134     
  Branches      15129    15120       -9     
============================================
- Hits          30031    30023       -8     
+ Misses        45455    45329     -126     
  Partials       5623     5623              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marshallward]

This appears to change some internal diagnostics used to inspect the layer energetics:

• dKEdt
• PE_to_KE

Since solutions are unchanged, it was decided that we will let this through without an answer preservation flag.

[marshallward]

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/23377 ✔️