Clean up non-standard syntax and whitespace#59
Merged
marshallward merged 1 commit intoJan 10, 2022
Conversation
Eliminated a number of instances of non-standard syntax from that described in https://github.com/NOAA-GFDL/MOM6/wiki/Code-style-guide. The changes include enforcing the MOM6-standard 2-point indentation convention, replacing 'if(A)' with 'if (A)', and changing logical comparison syntax like '.gt.' to '>' or '.eq.' to '=='. An old commented out block of code for debugging (detected by its use of non-standard syntax) was also eliminated. All answers and output are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #59 +/- ##
============================================
- Coverage 28.95% 28.95% -0.01%
============================================
Files 242 242
Lines 71557 71556 -1
============================================
- Hits 20717 20716 -1
Misses 50840 50840
Continue to review full report at Codecov.
|
marshallward
approved these changes
Jan 10, 2022
Member
|
And I merged the wrong PR.... well, let me back-verify this one. |
Member
|
This was accidentally merged before review and regression testing. Post-merge regriession testing: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14551 ✔️ |
This was referenced Jan 29, 2022
Hallberg-NOAA
added
the
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminated a number of instances of non-standard syntax from that described in
https://github.com/NOAA-GFDL/MOM6/wiki/Code-style-guide. The changes include
enforcing the MOM6-standard 2-point indentation convention, replacing 'if(A)'
with 'if (A)', and changing logical comparison syntax like '.gt.' to '>' or
'.eq.' to '=='. An old commented out block of code for debugging (detected by
its use of non-standard syntax) was also eliminated. All answers and output are
bitwise identical.