+Add get_netcdf_filename for a get_field_nc error#582
Merged
marshallward merged 3 commits intoApr 2, 2024
Conversation
Add get_netcdf_filename and use it to add useful details (the field and filenames in question) to a fatal error message in get_field_nc. All answers are bitwise identical, but there is a new public interface and some output is changed in cases where get_field_nc is failing.
Hallberg-NOAA
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #582 +/- ##
============================================
- Coverage 37.12% 37.12% -0.01%
============================================
Files 271 271
Lines 80794 80797 +3
Branches 15082 15082
============================================
Hits 29998 29998
- Misses 45195 45198 +3
Partials 5601 5601 ☔ View full report in Codecov by Sentry. |
marshallward
approved these changes
Apr 1, 2024
Member
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
Useful error output feedback. Not the only instance of the lack of this info though, and we should come back to this.
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22888 ✔️ |
This was referenced May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
get_netcdf_filename()and use it to add useful details (the field and filenames in question) to a fatal error message inget_field_nc(). All answers are bitwise identical, but there is a new public interface and some output is changed in cases whereget_field_nc()is failing.