Skip to content

Standardize code in calc_sfc_displacement#58

Merged
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:calc_sfc_disp_cleanup
Jan 10, 2022
Merged

Standardize code in calc_sfc_displacement#58
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:calc_sfc_disp_cleanup

Conversation

@Hallberg-NOAA
Copy link
Copy Markdown
Member

Slightly modified the recently added subroutine calc_sfc_displacement to
document the units of its variables and to follow the MOM6 code standards from
https://github.com/NOAA-GFDL/MOM6/wiki/Code-style-guide. The changes include
white-space corrections, changing logical comparison syntax like '.gt.' to '>',
and explicitly identifying where array syntax is used. All answers and output
are bitwise identical.

  Slightly modified the recently added subroutine calc_sfc_displacement to
document the units of its variables and to follow the MOM6 code standards from
https://github.com/NOAA-GFDL/MOM6/wiki/Code-style-guide.  The changes include
white-space corrections, changing logical comparison syntax like '.gt.' to '>',
and explicitly identifying where array syntax is used.  All answers and output
are bitwise identical.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2022

Codecov Report

Merging #58 (0e54bdd) into dev/gfdl (d838ccd) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl      #58   +/-   ##
=========================================
  Coverage     28.95%   28.95%           
=========================================
  Files           242      242           
  Lines         71556    71556           
=========================================
  Hits          20716    20716           
  Misses        50840    50840           
Impacted Files Coverage Δ
src/initialization/MOM_state_initialization.F90 19.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d838ccd...0e54bdd. Read the comment docs.

Copy link
Copy Markdown

@MJHarrison-GFDL MJHarrison-GFDL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve.

@Hallberg-NOAA
Copy link
Copy Markdown
Member Author

Hallberg-NOAA commented Jan 9, 2022

Matt Harrison has reviewed and approved this PR, which is essentially an appendix to PR #41.

This PR has passed TC testing and pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14535.

I would appreciate it if someone else with the right authorities could please click on the "Approve" button, and then the green button to merge in this PR.

Copy link
Copy Markdown
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @MJHarrison-GFDL (for real this time).

@marshallward
Copy link
Copy Markdown
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14553 ✔️

@marshallward marshallward merged commit 6da5c9b into NOAA-GFDL:dev/gfdl Jan 10, 2022
@Hallberg-NOAA Hallberg-NOAA added documentation Improvements or additions to documentation refactor Code cleanup with no changes in functionality or results labels Feb 1, 2022
@Hallberg-NOAA Hallberg-NOAA deleted the calc_sfc_disp_cleanup branch March 25, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation refactor Code cleanup with no changes in functionality or results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants