Add an option in hor_visc to adopt velocity thickness from continuity solver#579
Merged
Merged
Conversation
Runtime parameter USE_CONT_THICKNESS is added in hor_visc to let it use velocity-point thickness consistent with the continuity solver. Thicknesses are borrowed from BT_cont so only split mode is supported.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #579 +/- ##
============================================
+ Coverage 37.09% 37.13% +0.04%
============================================
Files 270 271 +1
Lines 80091 80776 +685
Branches 14939 15067 +128
============================================
+ Hits 29709 29998 +289
- Misses 44864 45178 +314
- Partials 5518 5600 +82 ☔ View full report in Codecov by Sentry. |
Hallberg-NOAA
approved these changes
Mar 21, 2024
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes seem like a valuable addition for exploring new algorithmic options, and they appear to me to be correctly implemented.
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22810 ✔️ 🟡 |
This was referenced May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime parameter
USE_CONT_THICKNESSis added in horizontal viscosity to let it use velocity-point thickness consistent with the continuity solver. Thickness at velocity points simply uses h[uv] in BT_cont type. So the option only applies to split mode.The purpose of this PR is to open the way for tests. A more general (and careful) implementation can be added later.